PR requests

substrait-io · Sep 3, 2024 · 5fa49e7 · 5fa49e7
1 parent bbc75dd
commit 5fa49e7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/proto/substrait/algebra.proto b/proto/substrait/algebra.proto
@@ -778,7 +778,6 @@ message NestedLoopJoinRel {
 message DuplicateEliminatedGetRel {
   RelCommon common = 1;
   ReferenceRel input = 2;
-  repeated Expression.FieldReference column_ids = 3;
 }
 
 message DuplicateEliminatedJoinRel {

diff --git a/site/docs/relations/physical_relations.md b/site/docs/relations/physical_relations.md
@@ -54,12 +54,12 @@ The Duplicate Eliminated Join is essentially a [Regular Join Operator](logical_r
 
 The duplicate eliminated join has two outputs.  The first output is no different than a regular join output.  The second output is the output to the duplicate eliminated get operator.  This output contains only the columns listed in the `duplicate_eliminated_columns` property.  This output must be emitted as soon as the build phase is complete.  This is because this output is required to compute the probe input.
 
-| Signature            | Value                                                                                        |
-| -------------------- |----------------------------------------------------------------------------------------------|
-| Inputs               | 2                                                                                            |
-| Outputs              | 1                                                                                            |
-| Property Maintenance | It is the same as the [Hash Equijoin Operator](physical_relations.md#hash-equijoin-operator) |
-| Direct Output Order  | Same as the [Join](logical_relations.md#join-operator) operator.                             |
+| Signature            | Value                                                                                                             |
+| -------------------- |-------------------------------------------------------------------------------------------------------------------|
+| Inputs               | 2                                                                                                                 |
+| Outputs              | 2 One output is from the deduplicated columns in the Duplicate Eliminated Get, and the second is the join output. |
+| Property Maintenance | It is the same as the [Hash Equijoin Operator](physical_relations.md#hash-equijoin-operator)                      |
+| Direct Output Order  | Same as the [Join](logical_relations.md#join-operator) operator.                                                  |
 
 ### Duplicate Eliminated Join Properties