Skip to content

Commit

Permalink
Address review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
jacques-n committed Aug 8, 2024
1 parent d02ab82 commit 3175d00
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions proto/substrait/algebra.proto
Original file line number Diff line number Diff line change
Expand Up @@ -883,14 +883,13 @@ message Expression {
int32 days = 1;
int32 seconds = 2;

// oneof ensures that a user can only use precision (and subseconds) or microseconds
oneof precision_mode {
int32 microseconds = 3 [deprecated = true]; // use precision and subseconds below, they cover and replace microseconds.
// Sub-second precision, 0 means the value given is in seconds, 3 is milliseconds, 6 microseconds, 9 is nanoseconds.
// Sub-second precision, 0 means the value given is in seconds, 3 is milliseconds, 6 microseconds, 9 is nanoseconds. Should be used with subseconds below.
int32 precision = 4;
}

// the number of fractional seconds using 1e(-precision) units. Should be ignored if microseconds is set above.
// the number of fractional seconds using 1e(-precision) units. Should only be used with precision field, not microseconds.
int64 subseconds = 5;
}

Expand Down
4 changes: 2 additions & 2 deletions proto/substrait/type.proto
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,11 @@ message Type {
Nullability nullability = 2;

// Sub-second precision, 0 means the value given is in seconds, 3 is milliseconds, 6 microseconds, 9 is nanoseconds, etc.
// if unset, treat as 6. this allows non-backwards breaking change
// if unset, treat as 6.
optional int32 precision = 3;
}

// An interval consisting of months, days, and nanoseconds
// An interval consisting of the components of both IntervalMonth and IntervalDay
message IntervalCompound {
uint32 type_variation_reference = 1;
Nullability nullability = 2;
Expand Down

0 comments on commit 3175d00

Please sign in to comment.