Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup: Update duckdb to get Latest Relation Definition #122

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Fixup: Update duckdb to get Latest Relation Definition #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1a4fd6
Update duckdb to get Latest Relation
anshuldata Nov 13, 2024
18fac9c
Exclude "windows_amd64_rtools" from archs
anshuldata Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/main_distribution.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
name: Build extension binaries
uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main
with:
duckdb_version: main
ci_tools_version: main
exclude_archs: "wasm_mvp;wasm_eh;wasm_threads;windows_amd64;windows_amd64_mingw"
duckdb_version: ca5af32c331f9d5ea49f7158d5c83a47f25b8b79
ci_tools_version: 5bdbe4d606d78dbd749f9578ba8ca639feece023
exclude_archs: "wasm_mvp;wasm_eh;wasm_threads;windows_amd64;windows_amd64_mingw;windows_amd64_rtools"
extension_name: substrait

2 changes: 1 addition & 1 deletion duckdb
Open in desktop
Submodule duckdb updated 292 files
2 changes: 1 addition & 1 deletion extension-ci-tools
Open in desktop
Submodule extension-ci-tools updated 14 files
+4 −5 .github/workflows/TestCITools.yml
+19 −11 .github/workflows/_extension_deploy.yml
+164 −65 .github/workflows/_extension_distribution.yml
+4 −1 README.md
+63 −0 config/distribution_matrix.json
+9 −2 docker/linux_amd64/Dockerfile
+8 −1 docker/linux_amd64_gcc4/Dockerfile
+9 −2 docker/linux_arm64/Dockerfile
+41 −8 makefiles/duckdb_extension.Makefile
+237 −0 makefiles/duckdb_extension_c_api.Makefile
+47 −0 makefiles/duckdb_extension_rs.Makefile
+64 −6 scripts/append_extension_metadata.py
+45 −0 scripts/configure_helper.py
+75 −0 scripts/modify_distribution_matrix.py
2 changes: 1 addition & 1 deletion src/to_substrait.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1317,7 +1317,7 @@ substrait::Rel *DuckDBToSubstrait::TransformGet(LogicalOperator &dop) {
auto &column_ids = dget.GetColumnIds();
for (auto col_idx : dget.projection_ids) {
auto struct_item = select->add_struct_items();
struct_item->set_field(static_cast<int32_t>(column_ids[col_idx]));
struct_item->set_field(static_cast<int32_t>(column_ids[col_idx].GetPrimaryIndex()));
// FIXME do we need to set the child? if yes, to what?
}
projection->set_allocated_select(select);
Expand Down
Loading