Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to extension-ci-tools, enable distribution of nightly versions #109

Merged
merged 10 commits into from
Sep 11, 2024

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Sep 11, 2024

Include #108, plus fixes to build system.

Note that while building there are a few warnings connected to targets like:

Makefile:20: warning: overriding commands for target `pull'
extension-ci-tools/makefiles/duckdb_extension.Makefile:122: warning: ignoring old commands for target `pull'
Makefile:43: warning: overriding commands for target `test_release'
extension-ci-tools/makefiles/duckdb_extension.Makefile:82: warning: ignoring old commands for target `test_release'
Makefile:46: warning: overriding commands for target `test_debug'
extension-ci-tools/makefiles/duckdb_extension.Makefile:85: warning: ignoring old commands for target `test_debug'
Makefile:63: warning: overriding commands for target `format'
extension-ci-tools/makefiles/duckdb_extension.Makefile:115: warning: ignoring old commands for target `format'
Makefile:69: warning: overriding commands for target `update'
extension-ci-tools/makefiles/duckdb_extension.Makefile:119: warning: ignoring old commands for target `update'

Those might need to double checked, relevant code is likely already in extension-ci-tools, but I am not completely sure.

@carlopi carlopi requested a review from pdet September 11, 2024 13:30
@carlopi
Copy link
Contributor Author

carlopi commented Sep 11, 2024

I think this should sort of work, although it might need some minor touches.

@pdet
Copy link
Contributor

pdet commented Sep 11, 2024

Thanks for picking this up!

I think the SQL tests are not running?
No test cases matched '/Users/runner/work/substrait/substrait/test/*'

@carlopi
Copy link
Contributor Author

carlopi commented Sep 11, 2024

@pdet: nice catch, up to the next

@pdet
Copy link
Contributor

pdet commented Sep 11, 2024

LGTM! Thanks Carlo!!

@pdet pdet merged commit 5327fe3 into substrait-io:main Sep 11, 2024
23 checks passed
@carlopi carlopi deleted the nightly_distribution branch September 11, 2024 15:01
@pdet
Copy link
Contributor

pdet commented Sep 11, 2024

@carlopi I just gave this a go and got

con.execute("FORCE INSTALL substrait FROM core_nightly")
duckdb.duckdb.HTTPException: HTTP Error: Failed to download extension "substrait" at URL "http://nightly-extensions.duckdb.org/v1.1.0/osx_arm64/substrait.duckdb_extension.gz" (HTTP 403)
Extension "substrait" is an existing extension.

@carlopi
Copy link
Contributor Author

carlopi commented Sep 11, 2024

Yes, I had seen it earlier, I think #110 solves this.

@carlopi
Copy link
Contributor Author

carlopi commented Sep 11, 2024

I think it worked:

FORCE INSTALL substrait from core_nightly;
LOAD substrait;
SELECT extension_name, extension_version, install_mode, installed_from FROM duckdb_extensions() WHERE extension_name = 'substrait';
┌────────────────┬───────────────────┬──────────────┬────────────────┐
│ extension_name │ extension_version │ install_mode │ installed_from │
│    varchar     │      varchar      │   varchar    │    varchar     │
├────────────────┼───────────────────┼──────────────┼────────────────┤
│ substrait      │ d8ca65b           │ REPOSITORY   │ core_nightly   │
└────────────────┴───────────────────┴──────────────┴────────────────┘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants