-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to extension-ci-tools, enable distribution of nightly versions #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this should sort of work, although it might need some minor touches. |
Thanks for picking this up! I think the SQL tests are not running? |
@pdet: nice catch, up to the next |
LGTM! Thanks Carlo!! |
@carlopi I just gave this a go and got
|
Yes, I had seen it earlier, I think #110 solves this. |
I think it worked: FORCE INSTALL substrait from core_nightly;
LOAD substrait;
SELECT extension_name, extension_version, install_mode, installed_from FROM duckdb_extensions() WHERE extension_name = 'substrait';
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include #108, plus fixes to build system.
Note that while building there are a few warnings connected to targets like:
Those might need to double checked, relevant code is likely already in extension-ci-tools, but I am not completely sure.