improved error checking

substrait-io · Jan 21, 2025 · e39ce8a · e39ce8a
1 parent 744e131
commit e39ce8a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/from_substrait.cpp b/src/from_substrait.cpp
@@ -648,7 +648,7 @@ shared_ptr<Relation> SubstraitToDuckDB::TransformReadOp(const substrait::Rel &so
 		if (sget.iceberg_table().direct().has_snapshot_id()) {
 			auto str = sget.iceberg_table().direct().snapshot_id();
 			int64_t snapshot_id = strtoimax(str.c_str(), nullptr, 10);
-			if (snapshot_id == 0) {
+			if (snapshot_id <= 0 || snapshot_id == std::numeric_limits<int64_t>::max()) {
 				throw InvalidInputException("Invalid snapshot id: " + sget.iceberg_table().direct().snapshot_id());
 			}
 			parameters.push_back(Value::UBIGINT(snapshot_id));