Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various build improvements #40

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dmacvicar
Copy link

  • Switch to using go modules
    • go builddoes the right thing
    • Note: I did not check go.sum in, but it can also be done
  • Use go-bindata via go generate
    • go-bindata is fetched as any other dependency
  • Decouple build logic from the container
  • Allows to build the same without the container. Put the logic in a Makefile and use that in the container
  • Note that in any case there is no need for go getanymore

@Fastidious
Copy link

With six open PRs, and no much happening, I am afraid the developer(s) aren't much active, if at all. 😢

@agonbar
Copy link

agonbar commented Mar 2, 2020

This project seems dead, and the maintainer its obviously missing, as proposal:

https://github.com/subspacecommunity/subspace

@dmacvicar I'm creating this and accepting any PR that seems logic, can I merge this fixes? or maybe do the PR e. I guess I'll spam this to all the other PRs.

@dmacvicar
Copy link
Author

Thanks for merging those!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants