Fixed IE issues #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause IE doesn't support it. 2 Replaced window.scrollX with window.pageXOffset because IE doesn't support it.
| @@ -34,7 +34,7 @@ | |||
| var datetimePickerEl; | |||
| var _this = this; | |||
| var removeEl = function(el) { | |||
| el && el.remove(); | |||
| el && el.parentElement.removeChild(el); | |||
There was a problem hiding this comment.
Why is this change required?
There was a problem hiding this comment.
Because IE doesn't recognize function remove and throw error with message "Object doesn't support property or method 'remove'". More details here: https://developer.mozilla.org/en-US/docs/Web/API/ChildNode/remove
subramaniam-s17
approved these changes
Jan 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 Replaced element.remove() with element.parentElement.removeChild because IE doesn't support it.
2 Replaced window.scrollX with window.pageXOffset because IE doesn't support it.