-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec version filter for cli init #751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following test is flaky |
ianhe8x
reviewed
Jan 14, 2022
ianhe8x
reviewed
Jan 14, 2022
Let me put back in the |
Added back the |
Closed
The template feature is a replacement for the original --starter. With --starter, it skips template selection. I think we should move on without --starter |
ianhe8x
approved these changes
Jan 17, 2022
bz888
pushed a commit
that referenced
this pull request
Jun 3, 2022
* spec version filter for init * use lodash and move inquirer setup after imports * add back --starter flag * Remove starter flag * unused import * update project defaults test * fix test * Add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a filter of templates for users chosen specVersion. If there are no templates for that specVersion (which should not be the case) then it falls back to a custom git remote & branch.