Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit interval metadata #740

Merged
merged 4 commits into from
Jan 11, 2022
Merged

Edit interval metadata #740

merged 4 commits into from
Jan 11, 2022

Conversation

fishmonger45
Copy link
Contributor

@fishmonger45 fishmonger45 commented Jan 10, 2022 •
edited
Loading

  • Changes the data that is updated during the interval, lastProcessedHeight and lastProcessedTimestamp must be tied to a transaction otherwise it can lead to an inconsistent db state. The targetHeight remains tied to an interval as this is the finalized target height of the chain that you are indexing. Db inconsistency is currently created in the following way:
block is processed --> interval event updates metadata --> block is rolled back but interval event updates are not
  • Should fix a critical issue that we are facing with the moonbeam dictionary project

@fishmonger45 fishmonger45 added the bug Something isn't working label Jan 10, 2022
@ianhe8x ianhe8x merged commit cabbd8e into subquery:main Jan 11, 2022
bz888 pushed a commit that referenced this pull request Jun 3, 2022
@fishmonger45
Edit interval metadata (#740)
aa52531 
* remove interval

* normalize signatures

* remove blockLastProcessed event listeners and add batch metdata update

* use bulk insert
@quinndiggitypolymath quinndiggitypolymath mentioned this pull request Aug 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianhe8x ianhe8x ianhe8x approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fishmonger45 @ianhe8x