-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Row count estimate #736
Row count estimate #736
Conversation
|
||
return metadata; | ||
} | ||
|
||
export const GetMetadataPlugin = makeExtendSchemaPlugin((build, options) => { | ||
const schemaName = options.pgSchemas; | ||
const [schemaName] = options.pgSchemas; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There wasn't any error before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. It gets cast to string
fine but it was really [string]
. Can't trust the types with a whole lot of any
being used here, but the plugin needs it so no avoiding.
Seems my chaintypes error pull that has been merged is causing problems with the CI. I'll fix this by either removing the process exit and moving it to the validate or mocking process exit in that test. |
@wqsz7xn I can merge this one and you fix it in another PR. |
* basic string encoded estimate * add row count estimate to metadata plugin * fix build * decompose schemaName to properly match type
Adds a row count estimate to the metadata plugin for query service. Although it uses a custom gql type rather than a generic json object.
Implements: #734
Example: