Detect changed project metadata #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianhe8x
reviewed
Jan 5, 2022
ianhe8x
reviewed
Jan 5, 2022
ianhe8x
approved these changes
Jan 6, 2022
bz888
pushed a commit
that referenced
this pull request
Jun 3, 2022
* detect changed metadata * remove non-genesis checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #731
Unhandled cases where the project has run and has stored metadata. Project then changes manifest entry (genesis hash, spec version or chain) and the project will not detect the changes made and attempt (and fail at) indexing. This pull now creates a detection for these metadata fields and exits the node with an assert.
Tested with recreating the scenario in issue linked