Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect changed project metadata #735

Merged
merged 2 commits into from
Jan 6, 2022
Merged

Conversation

fishmonger45
Copy link
Contributor

@fishmonger45 fishmonger45 commented Jan 5, 2022

Fixes: #731
Unhandled cases where the project has run and has stored metadata. Project then changes manifest entry (genesis hash, spec version or chain) and the project will not detect the changes made and attempt (and fail at) indexing. This pull now creates a detection for these metadata fields and exits the node with an assert.

Tested with recreating the scenario in issue linked

@fishmonger45 fishmonger45 added the bug Something isn't working label Jan 5, 2022
@fishmonger45 fishmonger45 requested a review from jiqiang90 January 5, 2022 00:11
@ianhe8x ianhe8x merged commit be62d41 into subquery:main Jan 6, 2022
bz888 pushed a commit that referenced this pull request Jun 3, 2022
* detect changed metadata

* remove non-genesis checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check manifest network and metadata stored genesis hash
2 participants