add unsafe flag for subql/node #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamcc21
changed the title
|
Can you also update the docs for this change? |
ianhe8x
reviewed
Nov 16, 2021
ianhe8x
reviewed
Nov 16, 2021
ianhe8x
reviewed
Nov 17, 2021
packages/node/src/main.ts
Outdated
| @@ -21,6 +21,13 @@ async function bootstrap() { | |||
| const indexerManager = app.get(IndexerManager); | |||
| await indexerManager.start(); | |||
| await app.listen(port); | |||
|
|
|||
| if (argv('unsafe')) { | |||
There was a problem hiding this comment.
move it before const app = await NestFactory.create
ianhe8x
approved these changes
Nov 17, 2021
bz888
pushed a commit
that referenced
this pull request
Jun 3, 2022
* add unsafe flag for subql/node, changed NodeVMOptions * add warning, enable wasm in sandbox with unsafe flag * change description of unsafe flag * Update main.ts Co-authored-by: Ian He <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested to make sure this flag works and with it you can for example make http requests. Although It was not so straight forward to make http requests in subql test project.