-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force-clean #619
force-clean #619
Conversation
@@ -29,6 +29,11 @@ export function getYargsOption() { | |||
demandOption: false, | |||
describe: 'Use local mode', | |||
}, | |||
'force-clean': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want a command so its like subql-node force-clean --subquery-name=app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm ok with what it is now, basically means clean data and start indexing. If we make it a subcommand, it will only be used to clean data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good points, i was tossing up which way to implement but ended up going with how it is now because during development it's very likely that you're going to want to clean the project and then start indexing immediately (make changes to schema, clean, and then index and test on the playground)
I think rather than remove record in db at the very beginning, we need to validate the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls check tests, not sure why it stuck there
my bad, didn't ping anyone when I made changes, @ianhe8x, this good? |
* force-clean * move force-clean to ensureProject * better description wording * refactor
obviously we don't want this all in
main.ts
but not entirely sure where to put it; all other options are small configuration options so don't have dedicated files