Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix publish failing with custom ds and assets #610

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Conversation

stwiname
Copy link
Collaborator

@stwiname stwiname commented Nov 5, 2021

A parsed project uses a Map type for assets because of limitations to class-validator but js-yaml cant dump the map type so we need to convert it to an object

@stwiname stwiname marked this pull request as ready for review November 5, 2021 01:03
@ianhe8x ianhe8x merged commit 1227a7d into main Nov 5, 2021
@ianhe8x ianhe8x deleted the fix-cli-publish branch November 5, 2021 03:39
bz888 pushed a commit that referenced this pull request Jun 3, 2022
* Fix publish failing with custom ds and assets

* Move isCustomDs and isRuntimeDs functions to common
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants