Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge metadata from query and node #555

Merged
merged 31 commits into from
Nov 12, 2021
Merged

merge metadata from query and node #555

merged 31 commits into from
Nov 12, 2021

Conversation

lamcc21
Copy link
Contributor

@lamcc21 lamcc21 commented Oct 22, 2021 •
edited
Loading

@lamcc21 lamcc21 changed the title Draft metadata task add subql/node ability to store metadata Oct 22, 2021
@lamcc21 lamcc21 marked this pull request as ready for review November 7, 2021 07:18
@lamcc21 lamcc21 changed the title add subql/node ability to store metadata merge metadata from query and node Nov 7, 2021
@lamcc21 lamcc21 marked this pull request as draft November 10, 2021 01:50
ianhe8x
ianhe8x requested changes Nov 10, 2021
View reviewed changes
packages/node/src/indexer/indexer.manager.ts Outdated Show resolved Hide resolved
packages/node/src/indexer/indexer.manager.ts Outdated Show resolved Hide resolved
@lamcc21 lamcc21 marked this pull request as ready for review November 11, 2021 21:29
@ianhe8x
Copy link
Collaborator

ianhe8x commented Nov 12, 2021

Congrats @lachlan1m

@ianhe8x ianhe8x merged commit cb7ebc8 into main Nov 12, 2021
@ianhe8x ianhe8x deleted the draft-metadata-task branch November 12, 2021 09:21
bz888 pushed a commit that referenced this pull request Jun 3, 2022
@lamcc21 @jiqiang90 @ianhe8x
merge metadata from query and node (#555)
defcf79 
* initial commit

* Fix

* Add subql/query ability to fetch metadata from table

* Add ability to insert network metadata into table

* addressed subql/query changes issues, fixed most problems with subql/node changes

* Update meta.module.ts

* fix for indexer.mananager.ts function return type

* Update api.service.ts

* Update api.service.ts

* fix indexer.manager.ts typo

* finish addressing concerns with draft pull request

* removing unnecessary variables, comments, changing incorrect configs

* updated useFactory, improved metadata plugin

* remove unnecessary imports, console.logs

* update logic in metadata plugin resolver

* update ensureMetadata method, store service, metadata query plugin

* Update types for metadata method

* add on interval store lastProcessedHeight

* add metadata plugin typechecking, tidy up store service and indexer manager

* add integration tests for fetching metadata from db

* remove beforeAll method in test

* fix plugin query to use parameterized query

* improve creation of key value pair

* add reduce functions when fetching metadata

* update config in graphql module test

* add graphql test, improve typing

* remove raw option findAll

* fix minor issues

* minor test fixes, merge conflicts fixes

Co-authored-by: Lachlan McCrae <[email protected]>
Co-authored-by: JQQQ <[email protected]>
Co-authored-by: Lachlan McCrae <[email protected]>
Co-authored-by: Ian He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianhe8x ianhe8x ianhe8x approved these changes

@jiqiang90 jiqiang90 Awaiting requested review from jiqiang90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lamcc21 @ianhe8x @jiqiang90