Support types mapping include float #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better we refactor the type mapping related codes in this PR. It's very easy to miss things when adding a new type. For example the part that related to POI. |
Closed
ianhe8x
reviewed
Oct 24, 2021
| return Object.keys(supportedTypes).findIndex((k) => k === type) > -1; | ||
| } | ||
|
|
||
| export class GeneralTypes { |
There was a problem hiding this comment.
I feel you just need a getTypeByScalarName(): TypeInterfaces, instead of a class.
ianhe8x
reviewed
Oct 24, 2021
| toTsType: TypeScalar | undefined; | ||
| toFieldScalar: FieldScalar | undefined; | ||
| toSequelizeType: SequelizeTypes | undefined; | ||
| toStoreOperation(data: any): Uint8Array | undefined; |
There was a problem hiding this comment.
Suggested change
| toStoreOperation(data: any): Uint8Array | undefined; | |
| toHashCode(data: any): Uint8Array | undefined; |
ianhe8x
reviewed
Oct 24, 2021
|
|
||
| export const Json = { | ||
| toFieldScalar: undefined, | ||
| toTsType: undefined, |
jiqiang90
force-pushed
the
support-float-type
branch
5 times, most recently
from
cc88157
to
172cae3
Compare
… add bn.js to dependency in common
jiqiang90
force-pushed
the
support-float-type
branch
from
e689788
to
67b6fba
Compare
ianhe8x
reviewed
Nov 14, 2021
| @@ -223,9 +224,9 @@ export function setJsonObjectType( | |||
| return graphQLJsonObject; | |||
| } | |||
|
|
|||
| type GraphQLNonListType = GraphQLScalarType | GraphQLObjectType<unknown, unknown>; // check | GraphQLInterfaceType | GraphQLUnionType | GraphQLEnumType; | |||
| type GraphQLNonListType = GraphQLScalarType | GraphQLObjectType<any, any>; // check | GraphQLInterfaceType | GraphQLUnionType | GraphQLEnumType; | |||
There was a problem hiding this comment.
unknown dose look better here
ianhe8x
approved these changes
Nov 16, 2021
bz888
pushed a commit
that referenced
this pull request
Jun 3, 2022
* support float and types mapping,change eslint complexity back to 20 , add bn.js to dependency in common * Fix bn.js dependency * change BN to bn * remove bn.js in dependencies * fix extractType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #530