-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ovn-failover #2865
Merged
Merged
Fix ovn-failover #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Created branch: z_pr2865/aswinsuryan/ovn-failover |
cd6e3db
to
40fb429
Compare
sridhargaddam
requested changes
Jan 5, 2024
pkg/routeagent_driver/handlers/ovn/gateway_route_handler_test.go
Outdated
Show resolved
Hide resolved
pkg/routeagent_driver/handlers/ovn/non_gateway_route_handler.go
Outdated
Show resolved
Hide resolved
tpantelis
requested changes
Jan 5, 2024
pkg/routeagent_driver/handlers/ovn/non_gateway_route_handler.go
Outdated
Show resolved
Hide resolved
40fb429
to
d23bf64
Compare
tpantelis
approved these changes
Jan 5, 2024
pkg/routeagent_driver/handlers/ovn/non_gateway_route_handler.go
Outdated
Show resolved
Hide resolved
d23bf64
to
c08956b
Compare
In OVN-Kubernetes out of order event lead to stale gatewayroutes and nongatewayroutes. This lead to incorrect flow in datatpath. Now gatewayroutes and nongatewayroutes use cluster ID instead of endpoint name. This ensures that there is only one resource and it gets updated when remote endpoint is created and updated and preventing stale endpoints. The gatewayroutes only care about remoteCIDRs does not matter if the remote gateway switches. Signed-off-by: Aswin Suryanarayanan <[email protected]>
c08956b
to
22c5f40
Compare
sridhargaddam
approved these changes
Jan 8, 2024
🤖 Closed branches: [z_pr2865/aswinsuryan/ovn-failover] |
aswinsuryan
added a commit
to aswinsuryan/submariner-website
that referenced
this pull request
Jan 10, 2024
Signed-off-by: Aswin Suryanarayanan <[email protected]>
tpantelis
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Jan 11, 2024
Signed-off-by: Aswin Suryanarayanan <[email protected]>
tpantelis
pushed a commit
to tpantelis/submariner-website
that referenced
this pull request
Feb 27, 2024
Signed-off-by: Aswin Suryanarayanan <[email protected]>
tpantelis
pushed a commit
to submariner-io/submariner-website
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Aswin Suryanarayanan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-handled
ready-to-test
When a PR is ready for full E2E testing
release-note-handled
release-note-needed
Should be mentioned in the release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OVN-Kubernetes out of order event leads to stale gatewayroutes and
nongatewayroutes. This leads to incorrect flow in datatpath. Now gatewayroutes
and nongatewayroutes use cluster ID instead of endpoint name. This ensures that
there is only one resource and it gets updated when remote endpoint is created
and updated and preventing stale endpoints. The gatewayroutes only care about
remoteCIDRs do not matter if the remote gateway switches.