Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LICENSE to tars #979

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Add LICENSE to tars #979

merged 3 commits into from
Oct 27, 2023

Conversation

Jaanki
Copy link
Contributor

@Jaanki Jaanki commented Oct 19, 2023

Add LICENSE file to the subctl binary tars. This is a requirement to enable krew installation of subctl.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr979/Jaanki/add_license
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@Jaanki Jaanki marked this pull request as draft October 19, 2023 07:12
@Jaanki Jaanki self-assigned this Oct 19, 2023
skitt
skitt requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@skitt skitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the requirement for a LICENSE file described anywhere? Please add a link to relevant documentation if you can find it.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@Jaanki
Add LICENSE to tars
0735e78 
Add LICENSE file to the subctl binary tars. This is a requirement to
enable krew installation of subctl.

Signed-off-by: Janki Chhatbar <[email protected]>
@Jaanki Jaanki marked this pull request as ready for review October 26, 2023 06:58
@Jaanki Jaanki requested a review from skitt October 26, 2023 06:58
@Jaanki
Copy link
Contributor Author

Jaanki commented Oct 26, 2023

Is the requirement for a LICENSE file described anywhere? Please add a link to relevant documentation if you can find it.

It is not mentioned anywhere but the CI job on my PR in krew-index repository (which adds manifest file for subctl) is failing because of missing LICENSE file in the tar.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Oct 26, 2023
@Jaanki Jaanki enabled auto-merge (rebase) October 27, 2023 05:19
@Jaanki Jaanki merged commit 006bd75 into submariner-io:devel Oct 27, 2023
28 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr979/Jaanki/add_license]

@Jaanki Jaanki deleted the add_license branch October 27, 2023 05:56
@Jaanki Jaanki added the backport This change requires a backport to eligible release branches label Oct 27, 2023
@Jaanki Jaanki mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sridhargaddam sridhargaddam sridhargaddam approved these changes

@skitt skitt skitt approved these changes

@mkolesnik mkolesnik Awaiting requested review from mkolesnik mkolesnik is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@tpantelis tpantelis Awaiting requested review from tpantelis tpantelis is a code owner

Assignees

@Jaanki Jaanki

Labels
backport This change requires a backport to eligible release branches backport-handled ready-to-test When a PR is ready for full E2E testing
Projects
No open projects
Submariner 0.17
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jaanki @submariner-bot @skitt @sridhargaddam