Use endpoints from Broker while validating overlapping CIDRs #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sridhargaddam
requested review from
Jaanki,
Oats87,
skitt and
tpantelis
as code owners
|
🤖 Created branch: z_pr913/sridhargaddam/validate-cidrs-broker |
sridhargaddam
added
the
backport
yboaron
reviewed
Sep 14, 2023
As part of the following PR[1], we no longer sync an endpoint from the Broker if the endpoint has any overlapping CIDRs with the local cluster. This was done to avoid issues on the Gateway node. Consequently, the subctl diagnose code should ideally examine the endpoints on Broker when validating overlapping CIDRs instead of inspecting the endpoints on the local cluster. This PR addresses this issue. [1] submariner-io/submariner#2263 Signed-off-by: Sridhar Gaddam <[email protected]>
sridhargaddam
force-pushed
the
validate-cidrs-broker
branch
from
b534ad8 to
d45eeab
Compare
yboaron
approved these changes
Sep 14, 2023
skitt
approved these changes
Sep 14, 2023
vthapar
approved these changes
Sep 14, 2023
|
🤖 Closed branches: [z_pr913/sridhargaddam/validate-cidrs-broker] |
This was referenced Sep 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the following PR[1], we no longer sync an endpoint from the Broker if the endpoint has any overlapping CIDRs with the local cluster. This was done to avoid issues on the Gateway node. Consequently, the subctl diagnose code should ideally examine the endpoints on Broker when validating overlapping CIDRs instead of inspecting the endpoints on the local cluster. This PR addresses this issue.
[1] submariner-io/submariner#2263