Automated backport of #1439: Fix invalid ServiceExport Conflict status condition #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This occurs if there's more than one service exported in a cluster. The conflict checking was processing all local EndpointSlices instead of only those corresponding to the service in question. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1440/tpantelis/automated-backport-of-#1439-upstream-release-0.16 |
aswinsuryan
approved these changes
Nov 17, 2023
tpantelis
added
release-note-needed
ready-to-test
sridhargaddam
approved these changes
Nov 17, 2023
|
🤖 Closed branches: [z_pr1440/tpantelis/automated-backport-of-#1439-upstream-release-0.16] |
tpantelis
deleted the
automated-backport-of-#1439-upstream-release-0.16
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #1439 on release-0.16.
#1439: Fix invalid ServiceExport Conflict status condition
For details on the backport process, see the backport requests page.