Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow halting on certificate errors #1408

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

skitt
Copy link
Member

@skitt skitt commented Oct 23, 2023

When certificate errors are encountered, the fix is usually to restart the affected pod. To allow this to happen automatically, add a configuration setting for the Lighthouse agent.

The setting is disabled by default; it will be enabled by default by the operator.

Depends on submariner-io/admiral#767

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr1408/skitt/halt-on-certificate-errors
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@skitt skitt added the backport label Oct 23, 2023
@skitt skitt force-pushed the halt-on-certificate-errors branch from 237983d to f8b39e5 Compare October 24, 2023 07:59
@github-actions
Copy link

This PR/issue depends on:

When certificate errors are encountered, the fix is usually to restart
the affected pod. To allow this to happen automatically, add a
configuration setting for the Lighthouse agent.

The setting is disabled by default; it will be enabled by default by
the operator.

Signed-off-by: Stephen Kitt <[email protected]>
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Oct 25, 2023
@tpantelis tpantelis enabled auto-merge (rebase) October 25, 2023 11:52
@tpantelis tpantelis merged commit 9b44616 into submariner-io:devel Oct 25, 2023
26 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr1408/skitt/halt-on-certificate-errors]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport backport-handled ready-to-test When a PR is ready for full E2E testing
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants