Ensure status field is deeply empty in CreateOrUpdate #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Oats87,
skitt and
sridhargaddam
as code owners
|
🤖 Created branch: z_pr811/tpantelis/ensure_empty_status |
...meaning any nested map fields are also empty. If a resource type has a non-pointer struct field, it appears as an empty map when converted to Unstructured so merely checking 'len' on the status map doesn't suffice. Specifically this was observed with the LoadBalancer field in the Service status. Added function to check if a map is deeply empty. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
ensure_empty_status
branch
from
ed51c15 to
576d523
Compare
skitt
approved these changes
Dec 7, 2023
aswinsuryan
approved these changes
Dec 8, 2023
|
🤖 Closed branches: [z_pr811/tpantelis/ensure_empty_status] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...meaning any nested map fields are also empty. If a resource type has a non-pointer struct field, it appears as an empty map when converted to
Unstructuredso merely checkinglenon the status map doesn't suffice. Specifically this was observed with the LoadBalancer field in the Service status. Added function to check if a map is deeply empty.