-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand variables on initializationOptions #709
Expand variables on initializationOptions #709
Conversation
Signed-off-by: Jack Cherng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I welcome this change and I'm looking forward to doing this in more places, especially the "command"
key. I hope you can find the time to address my nitpicks.
Signed-off-by: Jack Cherng <[email protected]>
Signed-off-by: Jack Cherng <[email protected]>
Signed-off-by: Jack Cherng <[email protected]>
If we do this, someone will suggest we infinitely recurse though the Looking at the reason for the request, it looks like the specific language server is the major need, combined with your additional desire to have your config portable. Appreciate offering to do the work yourself, but I want to discuss the value of this complexity to end users vs. maintenance burden. |
hello @jfcherng, if you don't mind I added your code to LSP-intelephese :) |
@predragnikolic sure. feel free to use it. |
This PR adds the ability to use some variables in
initializationOptions
.This PR comes from the following use case. In the settings of
intelephense
server, there are some path-related settings in theinitializationOptions
. ThelicenceKey
can be a path of a file containing a license key. I would like to keep it cross-platform and portable so I want it to be in ST's directory (or at least, in user's home directory~
).Related/similar to #1042