[Erlang] Tweak some scopes #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Java, field declarations are scoped as variable.other.member as well.
The `readwrite` should make clear variables beginning with capital letters are meant for reading and writing values, while lower case atoms are constants.
The #record{field=value} term represents an instantiation of a record,
which was declared by `-record(record, {field=value})` statement. Thus
the #record identifier can be interpreted as storage.type.
This commit uses `storage.type.record` instead of `storage.type.struct`
as this scope name is used for the meta scopes as well.
FichteFoll
approved these changes
Jul 22, 2020
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
* [Erlang] Rename variable.other.field to variable.other.member
* [Erlang] Rename entity.name.field to variable.other.member
In Java, field declarations are scoped as variable.other.member as well.
* [Erlang] Rename variables to variable.other.readwrite
The `readwrite` should make clear variables beginning with capital
letters are meant for reading and writing values, while lower case atoms
are constants.
* [Erlang] Use storage.type.record
The #record{field=value} term represents an instantiation of a record,
which was declared by `-record(record, {field=value})` statement. Thus
the #record identifier can be interpreted as storage.type.
This commit uses `storage.type.record` instead of `storage.type.struct`
as this scope name is used for the meta scopes as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2372
This PR proposes few scope changes which attempt to help color schemes to better highlight/distinguish the different types of entities used in Erlang.