Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Markdown] Add test case for ligatures vs. block-quote #2150

Merged
merged 1 commit into from
Oct 25, 2019
Merged

[Markdown] Add test case for ligatures vs. block-quote #2150

merged 1 commit into from
Oct 25, 2019

Conversation

deathaxe
Copy link
Collaborator

No description provided.

@wbond
Copy link
Member

wbond commented Oct 25, 2019

I'm not quite sure how this is testing that ligatures work?

@deathaxe
Copy link
Collaborator Author

This test case is just to ensure that > in >= is scoped as punctuation for an quotation depending on the indention level. If a line starts with 3 or more spaces, it should no longer be scoped as punctuation, which seems not to be tested until now at all.

Basically there is no real possibility to test ligatures without adding rules to scope them in a certain way, which I don't know would be worth/helpful?

@wbond
Copy link
Member

wbond commented Oct 25, 2019

Ok, just wanted to make sure I understood the intent!

@wbond wbond merged commit f60f80a into sublimehq:master Oct 25, 2019
@deathaxe deathaxe deleted the pr/markdown/test-block-quote branch October 25, 2019 16:48
mitranim pushed a commit to mitranim/Packages that referenced this pull request Mar 25, 2022
@deathaxe @mitranim
[Markdown] Add test case for ligatures vs. block-quote (sublimehq#2150)
34cd0ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deathaxe @wbond