Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] Add optional chaining and nullish coalescing. #2132

Merged
merged 4 commits into from
Oct 23, 2019

Conversation

Thom1729
Copy link
Collaborator

@Thom1729 Thom1729 commented Oct 18, 2019

Nullish coalescing (Stage 3)
Optional chaining (Stage 3)

The regexp to match a dotted property access is now \.(?!\?[\[(])\??, which is regrettable.

@Thom1729 Thom1729 changed the title Add optional chaining and nullish coalescing. [JavaScript] Add optional chaining and nullish coalescing. Oct 18, 2019
@michaelblyons
Copy link
Collaborator

The regexp to match a dotted property access is now \.(?!\?[\[(])\??, which is regrettable.

Do you want to make that a variable? It sees a lot of reuse, and it's no longer trivial.

@wbond wbond merged commit dce8f2c into sublimehq:master Oct 23, 2019
@Thom1729 Thom1729 deleted the javascript-optional branch October 23, 2019 17:45
mitranim pushed a commit to mitranim/Packages that referenced this pull request Mar 25, 2022
…#2132)

* [JavaScript] Add optional chaining and nullish coalescing.
* [JavaScript] Use variable for dot accessor.
* [JavaScript] Don't allow import.?meta.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants