Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust] scope support types in generics #1820

Merged
merged 1 commit into from
Jan 7, 2019
Merged

[Rust] scope support types in generics #1820

merged 1 commit into from
Jan 7, 2019

Conversation

keith-hall
Copy link
Collaborator

Fixes #1817

FichteFoll
FichteFoll approved these changes Jan 3, 2019
View reviewed changes
Copy link
Collaborator

@FichteFoll FichteFoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should definitely have a support.type vs storage.type discussion in Rust since they are essentially equivalent. Especially considering how special Box is, how fundamental a Vec, etc.

But that's for a different issue.

@wbond wbond merged commit 2c2772b into sublimehq:master Jan 7, 2019
@wbond
Copy link
Member

wbond commented Jan 7, 2019

Thanks!

@keith-hall keith-hall deleted the 1817_rust_generics branch January 7, 2019 18:45
deathaxe pushed a commit to deathaxe/sublime-packages that referenced this pull request Jun 9, 2019
@keith-hall @wbond
[Rust] scope support types in generics (sublimehq#1820)
dadd338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FichteFoll FichteFoll FichteFoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keith-hall @wbond @FichteFoll