[C/ObjC] Fix: be more lenient about macro identifiers with enum return types #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the class __declspec(dllimport) X {}; (From https://msdn.microsoft.com/en-us/library/dabb5z75.aspx) |
Also added tests for nested anonymous data structures
|
I added some fixes and tests for handling |
|
Thanks! I totally forgot about this PR! |
ismell
pushed a commit
to ismell/Packages
that referenced
this pull request
Dec 16, 2019
b94f72a [C/ObjC] Fix: be more lenient about macro identifiers with enum return types (sublimehq#1718) Makes the merge easier Signed-off-by: Raul E Rangel <[email protected]>
mitranim
pushed a commit
to mitranim/Packages
that referenced
this pull request
Mar 25, 2022
…n types (sublimehq#1718) * [C/ObjC] Fix: be more lenient about macro identifiers with enum return types * [C/Objective-C] Fix handling of __declspec() after struct/enum/union
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1712.
Since there were not any tests that failed after removing a line in the match rule, I am somewhat hesitant about merging this. @wbond let me know what could go wrong in this case.