Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: built-in functions bug #903

Closed
pdknsk opened this issue Apr 16, 2017 · 3 comments
Closed

makefile: built-in functions bug #903

pdknsk opened this issue Apr 16, 2017 · 3 comments

Comments

@pdknsk
Copy link

pdknsk commented Apr 16, 2017

1

The : apparently opens a scope without closing it. Works with other functions too.

$(warning Bug: $(BUG))
@rwols
Copy link
Contributor

rwols commented May 4, 2017

A naive fix would be to include the variable context in the main context, but I'm not sure if other things will start breaking in that case.

Just leaving this syntax test here for reference.

$(warning he:llo)
# ^ meta.support.function support.function.builtin
#         ^ meta.support.function
#               ^ meta.support.function punctuation.definition.variable.end

all: deps
	$(warning he:llo)
	# ^ meta.function.body meta.support.function support.function.builtin
	#         ^ meta.function.body meta.support.function
	#               ^ meta.function.body meta.support.function punctuation.definition.variable.end
deps:
	$(warning he:llo)

rwols added a commit to rwols/Packages that referenced this issue May 7, 2017
This was referenced May 7, 2017
@deathaxe
Copy link
Collaborator

deathaxe commented May 4, 2019

@wbond: This issue is closed by #974

deathaxe pushed a commit to deathaxe/sublime-packages that referenced this issue Aug 25, 2019
This PR proposes to close some already fixed issues, which were not (correctly) referenced in the fixing pull requests.

Closes sublimehq#442
Closes sublimehq#685
Closes sublimehq#691 (invalid)
Closes sublimehq#795
Closes sublimehq#807
Closes sublimehq#903
Closes sublimehq#1141
Closes sublimehq#1172
Closes sublimehq#1245
Closes sublimehq#1257
Closes sublimehq#1286
Closes sublimehq#1320
Closes sublimehq#1357
Closes sublimehq#1382 (wontfix)
Closes sublimehq#1403
Closes sublimehq#1451
Closes sublimehq#1453 (maybe)
Closes sublimehq#1472
Closes sublimehq#1495
Closes sublimehq#1540
Closes sublimehq#1542
Closes sublimehq#1565
Closes sublimehq#1576
Closes sublimehq#1625
Closes sublimehq#1880
Closes sublimehq#1898
Closes sublimehq#1940 (invalid)
@wbond
Copy link
Member

wbond commented Oct 24, 2019

This issue has been solved by a previous commit, hence it is being closed.

@wbond wbond closed this as completed Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants