Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on latest vscode October update #3

Closed
lkuoch opened this issue Oct 29, 2024 · 10 comments
Closed

Not working on latest vscode October update #3

lkuoch opened this issue Oct 29, 2024 · 10 comments

Comments

@lkuoch
Copy link

lkuoch commented Oct 29, 2024

On macos, with the latest vscode update the custom styles aren't applying :( @subframe7536

https://code.visualstudio.com/updates/v1_95

image
@subframe7536
Copy link
Owner

Seems work for me.

Have you ever reload the config? Upgrading the VSCode itself will remove the modification and you will need to reload it manually.

@subframe7536
Copy link
Owner

Initially I tested on my Mac and everything works. But then tried Windows version, it indeed breaks.

Now it should be fixed in v0.3.0

@ubranch
Copy link

ubranch commented Oct 30, 2024

it's not

@ubranch
Copy link

ubranch commented Oct 30, 2024

oh no sorry, it is but only after the manually restarting the VSCode

@Arelav
Copy link

Arelav commented Oct 30, 2024

oh no sorry, it is but only after the manually restarting the VSCode

Oh, definitely. After upgrading to the latest version and manually quit it works again. Thanks a lot.

@lkuoch
Copy link
Author

lkuoch commented Oct 31, 2024

@subframe7536 can confirm it's working now! Thanks alot ❤️

@lkuoch lkuoch closed this as completed Oct 31, 2024
@luan
Copy link

luan commented Oct 31, 2024

I'm getting this error on 1.95 (macOS) when reloading:

Fail to execute action, RangeError: Maximum call stack size exceeded

@subframe7536
Copy link
Owner

@luan can you try to set custom-ui-style.applyOnConfigurationChanged to false and see if this error disappeared?

@luan
Copy link

luan commented Nov 1, 2024

@luan can you try to set custom-ui-style.applyOnConfigurationChanged to false and see if this error disappeared?

Weirdly, it worked on one of my computers but not the other, I see someone else ran into this now too on #6 so maybe it's more generalized. But no, changing that setting didn't fix it on the computer that has the error.

@subframe7536
Copy link
Owner

@luan just enhance you VSCode's permissions, see FAQ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants