Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ‘¨πŸ»β€πŸ’» Puppeteer user acceptance tests #228

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

zmilonas
Copy link
Collaborator

@zmilonas zmilonas commented Sep 8, 2018

No description provided.

@zmilonas zmilonas self-assigned this Sep 8, 2018
@zmilonas zmilonas requested a review from subdavis as a code owner September 8, 2018 14:26
Copy link
Owner

@subdavis subdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a note about how to run these tests?

@zmilonas
Copy link
Collaborator Author

zmilonas commented Sep 8, 2018

@subdavis I will for sure do that when I broaden the test cases and agree on the final naming and path scheme.

For now you can play around using

yarn install
node_modules/.bin/mocha tests/integration/integration.js

That's it :)

@subdavis subdavis dismissed their stale review September 8, 2018 14:48

Still WIP.

@zmilonas
Copy link
Collaborator Author

Let's start from here. These test pass right now. I have a plan to create an end to end sample database unlock search and autofill test later but I might not get to it soon enough. Will have to think about adding qa html classes as well to stuff. @subdavis please review and run the tests on your machine :) Then we can add it to travis configuration (after that's merged as well)

@subdavis
Copy link
Owner

might take a while to get to the travis PR. Let's merge this first. I'll review this weekend

@zmilonas zmilonas changed the title [WIP] πŸ‘¨πŸ»β€πŸ’» Puppeteer user acceptance tests πŸ‘¨πŸ»β€πŸ’» Puppeteer user acceptance tests Sep 14, 2018
@zmilonas
Copy link
Collaborator Author

Thank you, I might also rename it first,
Do you agree these will be Chrome user acceptance tests
So I would put them under tests/uat/chrome.js as I add more tests I'll
probably split these UATs into view, database, storageProviders and
so on under uat

@subdavis
Copy link
Owner

I still don't know how this works. After generating a build, I get a message about failing to load options.html.

@zmilonas
Copy link
Collaborator Author

I think it might be related to the extension ID I hardcoded in the test. I have look into getting the installed extension ID again. I thought the web store one is going to be persistent but that's a really bad assumption πŸ˜‚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants