Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide to remain logged in until browser exits stopped working #349

Closed
PalpatineII opened this issue Aug 6, 2024 · 13 comments · Fixed by #355
Closed

Slide to remain logged in until browser exits stopped working #349

PalpatineII opened this issue Aug 6, 2024 · 13 comments · Fixed by #355

Comments

@PalpatineII
Copy link

Bug report

Steps to reproduce - current behaviour

I cannot really put my finger on it, but it used to be the case that Tusk remained logged in to the vault when you set the slider to 'Until browser exits', this does not seem to work anymore, I have to log in multiple times now, he remembers the session for a short while and then requires a new login.

What is the expected behaviour

The slider controls the time until next login is required

Additional remarks

Environment

OS: Windows 11 Enterprise 23H2,
Browser: Chrome 127.0.6533.89
Storage: Dropbox

@subdavis subdavis added the bug label Aug 6, 2024
@stromnt
Copy link

stromnt commented Aug 7, 2024

I am having the same problem. I have been using the Tusk extension for years with no problem.
I am on mac M1 running macOS 14.4.1 (23E224)
Chrome Version 127.0.6533.89 (Official Build) (arm64)

Unfortunately I cannot revert to the old extension. Every time I navigate away from chrome, I have to reenter my password in Tusk again, regardless of the slider settings.

It appears to be a "idle" timeout - the error appears in google extension.

@subdavis subdavis added the spooky A bug the maintainers cannot reproduce. label Aug 7, 2024
@subdavis
Copy link
Owner

subdavis commented Aug 7, 2024

I cannot reproduce this on Chrome Version 127.0.6533.89 (Official Build) (arm64)

Every time I navigate away from chrome

What does "Navigate away from chrome" mean?

It appears to be a "idle" timeout - the error appears in google extension.

Could you screenshot this error?

  • go to chrome://extensions/?id=fmhmiaejopepamlcjkncpgpdjichnecm
  • click on "inspect views -> service worker"
  • see what's going on in there while you try to unlock.

Have you tried to uninstall and reinstall Tusk?

@Phuturer
Copy link

Phuturer commented Aug 8, 2024

Same issue here. Since the new 2024 changes, the master password entered expires shortly after and has to be re-entered.

I've removed and reinstalled the extension (for some reason my webdav won't connect anymore, 401), but I have tried with the local file. Issue still exists.

I'm using Brave Version 1.68.137 Chromium: 127.0.6533.100 (Official Build) (64-bit)

@subdavis
Copy link
Owner

subdavis commented Aug 8, 2024

Yeah, this is tricky. I've tried this on 10 browsers across 2 computers / architectures / operating systems. I cannot reproduce it. Without a clear error or steps to reproduce, I don't have a path forward.

I also cannot restore the old version of Tusk, google was about to forcefully remove it from the store.

@RMutton
Copy link

RMutton commented Aug 8, 2024

I've had this happen multiple times across various instances of Chrome on different Windows machines.
It does not seem to happen when DevTools is open. A few minutes of regular browsing, tabbing to and from chrome and then the database is locked again when set to "Until browser exits" as well as 24 hours.

@subdavis
Copy link
Owner

subdavis commented Aug 9, 2024

It does not seem to happen when DevTools is open

That was the hint I needed. This is caused by the service worker life span. I can solve this by moving service worker memory into session storage.

@dinhacarina
Copy link

Hi @subdavis,
I had the same problem described above: I had to re-enter the KeePass master password every time I wanted to access an account with KeePass over and over again, although the slider to store the master password was activated.

Yesterday, an alert occured in my browser (Firefox), saying: "KeePass Tusk - Password Access and Autofill requires new authorizations."
I confirmed it, and KeePass Tusk was updated to v2024.8.6. Since then it is working again like it used to before: The master password is stored again.

Maybe this information could be helpful for anyone who is facing the same problem.

Firefox: 129.0
Windows 10 Enterprise 22H2

Firefox_KeePass

@subdavis
Copy link
Owner

subdavis commented Aug 9, 2024

@dinhacarina it's unlikely that this is the reason most people are having this problem. The firefox addon works differently than the chrome one, and these people are mostly on chrome. Firefox briefly upgraded to service worker, but MV3 barely works on firefox, so I downgraded again to MV2.

@stromnt
Copy link

stromnt commented Aug 9, 2024 via email

@subdavis subdavis added critical planned and removed needs more details spooky A bug the maintainers cannot reproduce. labels Aug 9, 2024
@subdavis
Copy link
Owner

subdavis commented Aug 9, 2024

This will be fixed in 2024.8.10 once it's been through the Chrome store review, probably tomorrow but possibly later if they take longer. I don't control that process

@stromnt
Copy link

stromnt commented Aug 10, 2024

This will be fixed in 2024.8.10 once it's been through the Chrome store review, probably tomorrow.

Wow - thank you - I love the tusk extension - really appreciate the support and upgrade. I would hate to have to find an alternative.

@stromnt
Copy link

stromnt commented Aug 10, 2024 via email

@PalpatineII
Copy link
Author

Great! Thanks for the very quick response and fix! I kept out of the discussion since there were more then enough people with good input!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants