This repository has been archived by the owner on Sep 21, 2024. It is now read-only.
fix: Cargo workspace inheritance in release-please
#362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsantell
approved these changes
May 8, 2023
cdata
deleted the
fix/support-cargo-workspace-inheritance-in-release-please
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the latest release (last week), we hit a really lame bug in
release-please: googleapis/release-please#1896TL;DR,
release-pleasedoesn't currently detect that a Cargo workspace member has changed, if that member uses workspace dependency inheritance and also one of its inherited dependencies changed at the workspace level.This bug led to a bad release where
noosphere-storagetechnically should have had a release due to a version change in an inherited dependency. Since it didn't have a release, it is now incompatible with all the other crates that did get released.This PR switches us to use a patched version of
release-pleasethat supports detecting changes in inherited dependencies. As this change makes its way into upstreamrelease-please, we will switch back.