-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Update regression tests for tutorials #2423
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant by testing one iteration was to test the entire optimization script by doing one iteration, not just test each call to SU2.
I guess we need to add FADO to the SU2 installation?
Yes, I am using FADO. Can you help in making FADO available during regression testing? |
I'll try to do it tonight. |
It's done, I have to update the init.py script but I'll do that after I check that the FADO examples work with the current version of SU2. |
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Proposed Changes
Add regression test for 90 degree bend adjoint design tutorial
Related Work
Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --all
to format old commits.