Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update regression tests for tutorials #2423

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

bigfooted
Copy link
Contributor

@bigfooted bigfooted commented Jan 15, 2025

Proposed Changes

Add regression test for 90 degree bend adjoint design tutorial

Related Work

Resolve any issues (bug fix or feature request), note any related PRs, or mention interactions with the work of others, if any.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

TestCases/tutorials.py Fixed Show fixed Hide fixed
Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant by testing one iteration was to test the entire optimization script by doing one iteration, not just test each call to SU2.
I guess we need to add FADO to the SU2 installation?

TestCases/tutorials.py Outdated Show resolved Hide resolved
TestCases/tutorials.py Show resolved Hide resolved
@bigfooted
Copy link
Contributor Author

What I meant by testing one iteration was to test the entire optimization script by doing one iteration, not just test each call to SU2. I guess we need to add FADO to the SU2 installation?

Yes, I am using FADO. Can you help in making FADO available during regression testing?

@pcarruscag
Copy link
Member

I'll try to do it tonight.

@pcarruscag
Copy link
Member

It's done, I have to update the init.py script but I'll do that after I check that the FADO examples work with the current version of SU2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants