-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update turbo ramps #2419
base: develop
Are you sure you want to change the base?
Update turbo ramps #2419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just some minor stuff and it's good to go.
…into feature_turbo_ramps
Not entirely sure why reg tests are failing on this branch, I am unable to reproduce the same results seen here locally; my local results match the reg test values. |
I was going to suggest compiler differences but the changes are huge
Run valgrind... |
Proposed Changes
The turbomachinery ramps were missing the option to ramp the translation rate in 2D and the ability to ramp the outlet mass flow, these have been added and the function has been made more general to accomodate these additions. It should be much easier to add ramps in the future.
Related Work
N/A
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --all
to format old commits.