-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending CFL adapt to include species transport #2298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Cristopher, Can you check how the underrelaxation is computed for species transport? |
…during simulations
So what is the deal with this PR? I see a question, no answer, and all I get is "merge branch develop" emails... |
pcarruscag
changed the title
[WIP] extending CFL adapt to include species transport
Extending CFL adapt to include species transport
Sep 16, 2024
pcarruscag
approved these changes
Sep 16, 2024
joshkellyjak
pushed a commit
to joshkellyjak/SU2
that referenced
this pull request
Sep 27, 2024
* extending CFL adapt to include species transport * add underrelaxation factor for the last species that is not computed during simulations * removing underrelaxation factor for species transport * adding CFLSpeciesReduction factor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
It would be good to extend the CFL_ADAPT option to include species transport for compressible flows.
I can add a test case if it is needed.
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --all
to format old commits.