Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending CFL adapt to include species transport #2298

Merged
merged 13 commits into from
Sep 16, 2024

Conversation

Cristopher-Morales
Copy link
Contributor

Proposed Changes

It would be good to extend the CFL_ADAPT option to include species transport for compressible flows.

I can add a test case if it is needed.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted
Copy link
Contributor

Hi Cristopher, Can you check how the underrelaxation is computed for species transport?

@pcarruscag
Copy link
Member

So what is the deal with this PR? I see a question, no answer, and all I get is "merge branch develop" emails...

@pcarruscag pcarruscag changed the title [WIP] extending CFL adapt to include species transport Extending CFL adapt to include species transport Sep 16, 2024
@Cristopher-Morales Cristopher-Morales merged commit 8e561ee into develop Sep 16, 2024
35 checks passed
@Cristopher-Morales Cristopher-Morales deleted the feature_CFL_adapt_species branch September 16, 2024 20:33
joshkellyjak pushed a commit to joshkellyjak/SU2 that referenced this pull request Sep 27, 2024
* extending CFL adapt to include species transport

* add underrelaxation factor for the last species that is not computed during simulations

* removing underrelaxation factor for species transport

* adding CFLSpeciesReduction factor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants