Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom inlets via python wrapper #2296

Merged
merged 4 commits into from
Jun 9, 2024
Merged

Custom inlets via python wrapper #2296

merged 4 commits into from
Jun 9, 2024

Conversation

pcarruscag
Copy link
Member

@pcarruscag pcarruscag commented Jun 8, 2024

Proposed Changes

SetMarkerCustomInletFlowVar0(marker, vertext, val)
SetMarkerCustomInletFlowVar1(marker, vertext, val)
SetMarkerCustomInletFlowDirection(marker, vertext, xyz)

Related Work

#1079

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@bigfooted
Copy link
Contributor

Thanks Pedro! For incompressible, we can use this but with different meaning at Var0, Var1, right?

For each of the other solvers like turbulence, species, a CustomTurbVar(marker,vertex,val,index) and a CustomSpeciesVar(marker,vertex,val,index) can then be introduced in the same way?

@pcarruscag
Copy link
Member Author

Yep, even for compressible flow there is a different meaning for mass flow inlet, vars 0 and 1 are density and velocity magnitude instead of total pressure and temperature, that's why I went with Var0 and Var1 for names.

Yeah good idea, I'll rename these functions to have "Flow" in the name.

@pcarruscag pcarruscag merged commit 8d294b2 into develop Jun 9, 2024
34 of 35 checks passed
@pcarruscag pcarruscag deleted the pywrapper_inlets branch June 9, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants