Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CFL Turbulence reduction option for adaptive cfl #2295

Merged
merged 7 commits into from
Jul 11, 2024
Merged

Fix CFL Turbulence reduction option for adaptive cfl #2295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
08a15c6
Fix CFL Turbulence reduction option for adaptive cfl
emaberman Jun 5, 2024
4cfe588
Apply suggestions from code review
pcarruscag Jun 5, 2024
2936a1f
Merge branch 'develop' into fix_TurbReduc_adapt_cfl
bigfooted Jun 10, 2024
42e146d
Merge
emaberman Jun 24, 2024
e7352dc
Merge branch 'develop' into fix_TurbReduc_adapt_cfl
emaberman Jul 3, 2024
3e486f5
Update AUTHORS.md
emaberman Jul 10, 2024
5473518
Merge branch 'develop' into fix_TurbReduc_adapt_cfl
emaberman Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions AUTHORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ Daumantas Kavolis
Dave Taflin
Eduardo Molina
Edwin van der Weide
Eitan Aberman
Ethan Alan Hereth
Florian Dittmann
Filip Hahs
Expand Down Expand Up @@ -108,6 +109,7 @@ Max Sagebaum
Michele Gaffuri
Mickael Philit
Mladen Banovic
Mor
Nat-1
Nicola Fonzi
Nijso Beishuizen
Expand Down Expand Up @@ -137,6 +139,7 @@ Trent Lukaczyk
Vinzenz Götz
VivaanKhatri
Wally Maier
Yair Mor-Yossef
Y. Chandukrishna
Zan Xu
Zcaic
Expand Down
3 changes: 2 additions & 1 deletion SU2_CFD/src/solvers/CSolver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1821,6 +1821,7 @@ void CSolver::AdaptCFLNumber(CGeometry **geometry,
/* Loop over all points on this grid and apply CFL adaption. */

su2double myCFLMin = 1e30, myCFLMax = 0.0, myCFLSum = 0.0;
const su2double CFLTurbReduction = config->GetCFLRedCoeff_Turb();

SU2_OMP_MASTER
if ((iMesh == MESH_0) && fullComms) {
Expand Down Expand Up @@ -1885,7 +1886,7 @@ void CSolver::AdaptCFLNumber(CGeometry **geometry,
CFL *= CFLFactor;
solverFlow->GetNodes()->SetLocalCFL(iPoint, CFL);
if ((iMesh == MESH_0) && solverTurb) {
solverTurb->GetNodes()->SetLocalCFL(iPoint, CFL);
solverTurb->GetNodes()->SetLocalCFL(iPoint, CFL * CFLTurbReduction);
}

/* Store min and max CFL for reporting on the fine grid. */
Expand Down
2 changes: 1 addition & 1 deletion TestCases/hybrid_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ def main():
Jones_tc_restart.cfg_dir = "turbomachinery/APU_turbocharger"
Jones_tc_restart.cfg_file = "Jones_restart.cfg"
Jones_tc_restart.test_iter = 5
Jones_tc_restart.test_vals = [-6.594590, -2.792279, -14.336129, -8.776066, -11.371439, -5.845633, 73273, 73273, 0.019884, 82.491]
Jones_tc_restart.test_vals = [-6.614623, -3.001323, -14.336147, -8.776081, -11.382919, -5.852327, 73273, 73273, 0.019884, 82.491]
test_list.append(Jones_tc_restart)

# 2D axial stage
Expand Down
2 changes: 1 addition & 1 deletion TestCases/parallel_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,7 @@ def main():
Jones_tc_restart.cfg_dir = "turbomachinery/APU_turbocharger"
Jones_tc_restart.cfg_file = "Jones_restart.cfg"
Jones_tc_restart.test_iter = 5
Jones_tc_restart.test_vals = [-6.594590, -2.792281, -14.336129, -8.776067, -11.371439, -5.845633, 73273, 73273, 0.019884, 82.491]
Jones_tc_restart.test_vals = [-6.614623, -3.001323, -14.336147, -8.776081, -11.382919, -5.852327, 73273, 73273, 0.019884, 82.491]
test_list.append(Jones_tc_restart)

# 2D axial stage
Expand Down
2 changes: 1 addition & 1 deletion TestCases/serial_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@ def main():
Jones_tc_restart.cfg_dir = "turbomachinery/APU_turbocharger"
Jones_tc_restart.cfg_file = "Jones_restart.cfg"
Jones_tc_restart.test_iter = 5
Jones_tc_restart.test_vals = [-6.594586, -2.792279, -14.336132, -8.776068, -11.371439, -5.845632, 73273, 73273, 0.019884, 82.491]
Jones_tc_restart.test_vals = [-6.614623, -3.001323, -14.336147, -8.776081, -11.382919, -5.852327, 73273, 73273, 0.019884, 82.491]
test_list.append(Jones_tc_restart)

# 2D axial stage
Expand Down