Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CHT boundary problem for flamelet computations #2283

Merged
merged 6 commits into from
May 18, 2024
Merged

Conversation

Cristopher-Morales
Copy link
Contributor

@Cristopher-Morales Cristopher-Morales commented May 15, 2024

Proposed Changes

Continuation of previous pull request #2281

[CHT + flamelet was only working if there was an additional isothermal wall present.]

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@Cristopher-Morales Cristopher-Morales changed the title [WIP] CHT_WALL_INTERFACE flamelet solver CHT_WALL_INTERFACE flamelet solver May 17, 2024
@bigfooted bigfooted changed the title CHT_WALL_INTERFACE flamelet solver Fix CHT boundary problem for flamelet computations May 17, 2024
@bigfooted
Copy link
Contributor

To me it looks like a better solution compared to the previous one because it prevents going into the isothermal wall function unnecessarily. LGTM, but maybe @pcarruscag can have a second look?

@bigfooted bigfooted merged commit c0324a4 into develop May 18, 2024
34 of 36 checks passed
@bigfooted bigfooted deleted the feature_fix_cht branch May 18, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants