Fix marker engine inflow #2278
Merged
Fix marker engine inflow #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added mach number evaluation for the engine boundaries. Decoupled the engine marker evaluation frequency from screen write frequency
Defining the option BC_EVAL_FREQ, for setting the evaluation frequency for the Engine and Actuator markers
Defining option BC_EVAL_FREQ, to set the evaluation frequency for Engine and Actuator Disk Markers
Test case for marker_engine_inflow
…estCases/engine/marker_engine_inflow/inv_channel_engine_inflow.cfg
pcarruscag
reviewed
May 12, 2024
TestCases/engine/marker_engine_inflow/inv_channel_engine_inflow.cfg
Outdated
Show resolved
Hide resolved
pcarruscag
reviewed
May 12, 2024
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Co-authored-by: Pedro Gomes <[email protected]>
Changed the mesh to an existing mesh in the repository
Changing the mesh file to an existing mesh
bigfooted
reviewed
May 14, 2024
bigfooted
reviewed
May 14, 2024
bigfooted
reviewed
May 14, 2024
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
Co-authored-by: Nijso <[email protected]>
TestCases/engine/marker_engine_inflow/inv_channel_engine_inflow.cfg
Outdated
Show resolved
Hide resolved
Changed Case Description, Author, Date and File Version
|
Hello I am sorry if it is obvious but is there way to tell where the code style checks fails on the files? Looking at the the details section , only thing I can understand is that it failed to trim some trailing white spaces. |
|
If you install the precommit hook it will take care of formatting for you https://su2code.github.io/docs_v7/Style-Guide/ |
|
@BerkeCan97 can you run pre-commit on the files? We can then continue merging this. |
Done, sorry it took so long. |
pcarruscag
reviewed
Aug 14, 2024
There was a problem hiding this comment.
If this file is not used in one of the *_regression.py files we should remove it.
Co-authored-by: Pedro Gomes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Related Work
Fix for issue #2274 .
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.