Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for ASLR/tsan incompatibility #2242

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

jblueh
Copy link
Contributor

@jblueh jblueh commented Mar 15, 2024

Proposed Changes

Explore a workaround along the lines of openvswitch/ovs@fa0dfa1 to fix #2241

Related Work

#2241

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@jblueh jblueh changed the title [WIP] Workaround for ASLR/tsan incompatibility Workaround for ASLR/tsan incompatibility Mar 15, 2024
@jblueh
Copy link
Contributor Author

jblueh commented Mar 15, 2024

The changes do fix #2241, thread sanitizer builds and tests execute without crashing. The workaround is only needed until a corresponding fix in the github runner is deployed, which will take around a week (actions/runner-images#9491 (comment)). We could merge this now and roll it back later. @pcarruscag

Copy link
Member

@pcarruscag pcarruscag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks for the quick fix 👍

@pcarruscag pcarruscag merged commit f817924 into develop Mar 15, 2024
31 checks passed
@pcarruscag pcarruscag deleted the tsan_workaround branch March 15, 2024 18:09
@jblueh jblueh mentioned this pull request Aug 13, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants