-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update turbomachinery testcases and regression tests #2158
Conversation
Hi Ale, can you add the mesh (from the workshop I presume) to the Testcases repo with a restart file and then use that to run a coupled iterations for regression testing? We may need to wait for the turbo outputs PR |
Hi Pedro, I'm adding them now. For the regresstion testing (sorry for the silly question, I'm a bit of a novice), is it enough to run the single test case or should I do the proper regression test with provided python script? |
Look for Jones_tc_restart in parallel_regression.py and that should help you set up the regression. |
Thanks for tip! |
Hi Pedro, I added the regresion tests, and mesh and restart to the |
Adding supporting comment to TURBO_PERF_KIND keyword Co-authored-by: Josh Kelly <[email protected]>
adding TURBO_PERF_KIND
Update residuals in serial regression
Update residual values in parallel regression test
TestCases/turbomachinery/Aachen_turbine/aachen_3D_MP_restart.cfg
Outdated
Show resolved
Hide resolved
fix residual values
removing unused chauchy criterion
Removing unused Cauchy convergence criterion
Hi @pcarruscag and @joshkellyjak, the parallel and serial regression tests are successful, but the tsan tests keep failing. |
@jblueh are the tsan tests using a special version of CoDi?
Does it need some kind of update? |
This branch was green just a couple of day ago https://github.com/su2code/SU2/actions/runs/8264374345 |
No, CoDi should be fine. Tsan does not need a special version of CoDi and the correct commit is checked out a couple of lines below the quoted ones. Tsan is failing in other PRs, too. There seems to be a general issue with tsan and github runners, I am looking into it right now. |
Removing duplicate config
leaner config file
Removing file version from config
TestCases/turbomachinery/Aachen_turbine/aachen_3D_MP_restart.cfg
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks lgtm
@alecappiello develop is updated with a fix for the thread sanitizer issue, it should fix your CI pipeline once you merge it into your branch |
Thanks a lot! I've just done it and tsan tests are indeed not failing anymore! |
Proposed Changes
I just added a new folder in the Turbomachinery test cases, containing the configuration files for the Aachen turbine test case
pre-commit run --all
to format old commits.