Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix to selector-list-comma-space-before #3447

Merged
merged 3 commits into from
Jul 15, 2018
Merged

Add autofix to selector-list-comma-space-before #3447

merged 3 commits into from
Jul 15, 2018

Conversation

ota-meshi
Copy link
Member

Which issue, if any, is this issue related to?

selector-list-comma-space-before in #2829

Is there anything in the PR that needs further explanation?

ex.

  • option: always***

    code:

    a,b {}

    fixed:

    a ,b {}
  • option: never***

    code:

    a ,b {}

    fixed:

    a,b {}

@jeddy3 jeddy3 changed the title Add autofix to selector-list-comma-space-before Add autofix to selector-list-comma-space-before Jul 9, 2018
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ota-meshi Thank you!

Tests LGTM, and logic looks solid.

@@ -8,6 +8,8 @@ Require a single space or disallow whitespace before the commas of selector list
* The space before this comma */
```

The `--fix` option on the command line can automatically fix all of the problems reported by this rule.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor update to make it like the other READMEs:

The `--fix` option on the [command line](../../../docs/user-guide/cli.md#autofixing-errors) can automatically fix all of the problems reported by this rule.

@ota-meshi
Copy link
Member Author

@jeddy3 Thank you for review!
I changed it, so please check it.

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ota-meshi Thanks making the changes!

LGTM

@ntwb ntwb merged commit 6e10329 into stylelint:master Jul 15, 2018
@ntwb
Copy link
Member

ntwb commented Jul 15, 2018

Changelog updated in: 217f036

Added: selector-list-comma-space-before autofix (#3447).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants