Release 15.4.0 #6743

mattxwang · 2023-03-29T05:43:39Z

Following up from the conversation in #6725. To summarize, we have a new rule, new CLI flag + new alias, one rule bugfix, and one performance fix. See the in-progress changelog.

We could wait on #6742 depending on its complexity; curious for other thoughts!

(I've never done a release before, though I'm happy to take it up if others don't have time. I may not have some permissions though!)

ybiquitous · 2023-03-29T09:43:38Z

@mattxwang Thanks for opening this issue. I think it's OK to release 15.4.0 (maybe this weekend).

I may not have some permissions though!

Unfortunately, you don't have permission to publish packages to the npm registry, and I cannot grant you permission due to my lack of rights. 😓
(cc @jeddy3)

So, I'll take over at this time. I appreciate your proposal. 😄

ybiquitous · 2023-03-29T10:08:43Z

We could wait on #6742 depending on its complexity; curious for other thoughts!

Merged. 👍🏼

So, we can ship our standard config together:

Add media-feature-range-notation: "context" rule stylelint-config-standard#275

ybiquitous · 2023-03-30T00:47:24Z

I'd like to include the following in v15.4.0:

Fix deprecation warnings for disabled rules #6747

mattxwang · 2023-03-30T02:20:08Z

Sounds good, just dropped a review.

for stylelint/stylelint-config-standard#275, would you like me to open a PR in the repo to turn it on? Happy to do so, but not sure if it's already in progress.

ybiquitous · 2023-03-30T02:54:37Z

for stylelint/stylelint-config-standard#275, would you like me to open a PR in the repo to turn it on? Happy to do so, but not sure if it's already in progress.

@mattxwang Thanks for your proposal. Please do so!

ybiquitous · 2023-03-30T07:43:33Z

It might be good timing to publish also create-stylelint: stylelint/create-stylelint@0.2.0...main

ybiquitous · 2023-03-30T13:55:53Z

@mattxwang Sorry for my misunderstanding. I just invited you to publish packages: stylelint, stylelint-config-recommended, and stylelint-config-standard. Could you check the invitations?

Also, I just removed inactive maintainers from these packages.
(cc @stylelint/owners)

mattxwang · 2023-03-31T06:59:57Z

No worries at all! Confirming on my end that I've received the invitations.

Would you prefer to continue taking point on this release? Happy to help out however possible!

ybiquitous · 2023-03-31T13:23:01Z

@mattxwang Could you try the release workflow if you are available this weekend? Our maintainer guide should help you.

I guess you don't have access to our Twitter account, so I'll do only the last job of tweeting the announcement instead of you. (@jeddy3 manages all accounts related to Stylelint, not me)

Feel free to ask me if you have any questions.

mattxwang · 2023-03-31T20:18:15Z

Sounds good, will do!

mattxwang · 2023-04-01T03:34:40Z

Hi @ybiquitous, sorry to bother again - unfortunately, I don't have permissions to force push to main (i.e. the same problem as create-stylelint). Would you be able to help me here?

Closes #275; also ref: stylelint/stylelint#6743

ybiquitous · 2023-04-01T04:00:30Z

@mattxwang No problem. I just changed the repo setting. Can you try it again?

mattxwang · 2023-04-01T04:01:49Z

Hm, no dice @ybiquitous - same error as before (protected branch hook declined). Tried git push and git push --force.

ybiquitous · 2023-04-01T04:11:08Z

Umm. Can you paste the error log here? You should have push access to the main branch 🤔

mattxwang · 2023-04-01T04:12:02Z

Sure!

$ git push
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: At least 1 approving review is required by reviewers with write access. 10 of 10 required status checks are expected.
To github.com:stylelint/stylelint.git
 ! [remote rejected]   main -> main (protected branch hook declined)
error: failed to push some refs to 'github.com:stylelint/stylelint.git'

$ git push --force
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
remote: error: GH006: Protected branch update failed for refs/heads/main.
remote: error: At least 1 approving review is required by reviewers with write access. 10 of 10 required status checks are expected.
To github.com:stylelint/stylelint.git
 ! [remote rejected]   main -> main (protected branch hook declined)
error: failed to push some refs to 'github.com:stylelint/stylelint.git'

ybiquitous · 2023-04-01T04:13:14Z

Thanks. Is the same error raised when running npm run release?

(BTW, we should avoid force-push to the main branch 😅 )

mattxwang · 2023-04-01T04:17:14Z

Hm, so all the steps to publish to npm did work - e.g. there is a 15.4.0 of Stylelint.

When I first ran npm run release, everything worked up until pushing the tag; this is where I first got the error.

Now, my main has one extra commit:

$ git log
commit 5b4a8e3ab2579fc0c4eb7c363e034a568d1be053 (HEAD -> main, tag: 15.4.0)
Author: Matthew Wang <[email protected]>
Date:   Fri Mar 31 20:32:56 2023 -0700

    15.4.0

If I run npm run release again after-the-fact, it prompts be about creating a new version - which I assume is not what we'd want.

Any advice on what to do? Could it be that the branch protection rule is "more important" than the branch permission you sent above? I know repositories have a feature that prevents admins from force-pushing as well.

(BTW, we should avoid force-push to the main branch 😅 )

Agreed, it felt a bit strange to type this out. I'll stick to git push from now on!

ybiquitous · 2023-04-01T04:18:48Z

OK, you are now admin in the repo. Can you try push again?

mattxwang · 2023-04-01T04:19:13Z

Gotcha, that worked - just ran git push. Feel free to de-admin me now!

mattxwang · 2023-04-01T04:27:21Z

On a related note - I'm also not able to do the same for stylelint-config-standard (stylelint/stylelint-config-standard#284). Is a temporary admin the solution that works in this situation? Or, would you prefer to explore a different option (since it certainly feels awkward)?

ybiquitous · 2023-04-01T04:27:59Z

I just updated the following repos' settings again to make things simple:
(you are now admin in the repos)

stylelint
stylelint-config-recommended
stylelint-config-standard
create-stylelint

ybiquitous · 2023-04-01T04:34:25Z

@mattxwang Sorry for the inconvenience. 🙇🏼

I will recommend you for an owner-team member when @jeddy3 comes back, since you have a passion for Stylelint!

mattxwang · 2023-04-01T04:38:11Z

Sorry for the inconvenience.

Haha, not a problem at all - very sympathetic, onboarding new people and permissions is always tricky!

I will recommend you for an owner-team member ... since you have a passion for Stylelint!

Aw, thank you! Also understand if that doesn't end up being possible for whatever reason (I am still very new in the grand scheme of things); just excited to help out however I can 😊

mattxwang · 2023-04-01T04:59:57Z

After merging stylelint/stylelint.io#311, I've verified that the site has been updated (ex the Changelog has been updated, the text for declaration-block-no-redundant-longhand-properties is updated); and, the demo is updated as well; for example, here is a reproducible demo for the new no-unknown-custom-properties rule!

I think all that's left is now the tweet, unless I've missed anything else. Thanks for your timely support @ybiquitous!

ybiquitous · 2023-04-01T05:02:03Z

@mattxwang Congrats on your first release!

ybiquitous · 2023-04-01T05:16:21Z

Tweet done! 🎉

Thank you so much for your contribution and support, everyone!

mattxwang added the status: needs discussion triage needs further discussion label Mar 29, 2023

mattxwang mentioned this issue Mar 29, 2023

Prepare release #6725

Merged

mattxwang mentioned this issue Mar 30, 2023

Prepare 32.0.0 stylelint/stylelint-config-standard#284

Merged

mattxwang mentioned this issue Mar 31, 2023

Release 0.3.0 stylelint/create-stylelint#19

Closed

mattxwang added a commit to stylelint/stylelint-config-standard that referenced this issue Apr 1, 2023

Prepare 32.0.0 (#284)

68bfda2

Closes #275; also ref: stylelint/stylelint#6743

ybiquitous added status: wip is being worked on by someone and removed status: needs discussion triage needs further discussion labels Apr 1, 2023

ybiquitous closed this as completed Apr 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 15.4.0 #6743

Release 15.4.0 #6743

mattxwang commented Mar 29, 2023 •

edited by ybiquitous

Loading

ybiquitous commented Mar 29, 2023

ybiquitous commented Mar 29, 2023

ybiquitous commented Mar 30, 2023

mattxwang commented Mar 30, 2023

ybiquitous commented Mar 30, 2023

ybiquitous commented Mar 30, 2023

ybiquitous commented Mar 30, 2023

mattxwang commented Mar 31, 2023

ybiquitous commented Mar 31, 2023

mattxwang commented Mar 31, 2023

mattxwang commented Apr 1, 2023

ybiquitous commented Apr 1, 2023

mattxwang commented Apr 1, 2023

ybiquitous commented Apr 1, 2023

mattxwang commented Apr 1, 2023

ybiquitous commented Apr 1, 2023 •

edited

Loading

mattxwang commented Apr 1, 2023

ybiquitous commented Apr 1, 2023

mattxwang commented Apr 1, 2023

mattxwang commented Apr 1, 2023

ybiquitous commented Apr 1, 2023 •

edited

Loading

ybiquitous commented Apr 1, 2023

mattxwang commented Apr 1, 2023

mattxwang commented Apr 1, 2023

ybiquitous commented Apr 1, 2023

ybiquitous commented Apr 1, 2023

Release 15.4.0 #6743

Release 15.4.0 #6743

Comments

mattxwang commented Mar 29, 2023 • edited by ybiquitous Loading

ybiquitous commented Mar 29, 2023

ybiquitous commented Mar 29, 2023

ybiquitous commented Mar 30, 2023

mattxwang commented Mar 30, 2023

ybiquitous commented Mar 30, 2023

ybiquitous commented Mar 30, 2023

ybiquitous commented Mar 30, 2023

mattxwang commented Mar 31, 2023

ybiquitous commented Mar 31, 2023

mattxwang commented Mar 31, 2023

mattxwang commented Apr 1, 2023

ybiquitous commented Apr 1, 2023

mattxwang commented Apr 1, 2023

ybiquitous commented Apr 1, 2023

mattxwang commented Apr 1, 2023

ybiquitous commented Apr 1, 2023 • edited Loading

mattxwang commented Apr 1, 2023

ybiquitous commented Apr 1, 2023

mattxwang commented Apr 1, 2023

mattxwang commented Apr 1, 2023

ybiquitous commented Apr 1, 2023 • edited Loading

ybiquitous commented Apr 1, 2023

mattxwang commented Apr 1, 2023

mattxwang commented Apr 1, 2023

ybiquitous commented Apr 1, 2023

ybiquitous commented Apr 1, 2023

mattxwang commented Mar 29, 2023 •

edited by ybiquitous

Loading

ybiquitous commented Apr 1, 2023 •

edited

Loading

ybiquitous commented Apr 1, 2023 •

edited

Loading