This repository has been archived by the owner on Feb 9, 2023. It is now read-only.
Fix CI workflow #240
Merged
Fix CI workflow #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
puku0x
commented
Nov 30, 2021
This comment has been minimized.
This comment has been minimized.
ybiquitous
reviewed
Dec 2, 2021
There was a problem hiding this comment.
@puku0x Thank you for creating the PR! Can you check my review, please?
ybiquitous
reviewed
Dec 2, 2021
There was a problem hiding this comment.
@puku0x Thanks for the quick fix! In addition, could you please do the following if you have time?
- Simplify the
lintjob removing the matrix and specifyinglts/*. - Remove needless
env.CIbecause Actions adds it by default
|
@ybiquitous Sure! I thought the same thing about |
|
It seems |
|
Let's remove the matrix from the |
|
Sure. I will make it like |
|
Done! |
ybiquitous
approved these changes
Dec 2, 2021
There was a problem hiding this comment.
@puku0x Thank you so much! I've left a trivial suggestion, but this PR looks good to me! 👍🏼
Co-authored-by: Masafumi Koba <[email protected]>
ybiquitous
approved these changes
Dec 2, 2021
abdonrd
approved these changes
Dec 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None, as it's a CI fix.
npmshould respect its supported Node.js version.actions/setup-node@v2supports~/.npmcache.