-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Create React App example results in error #1446
Fix: Create React App example results in error #1446
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the package updates!
examples/cra/package.json
Outdated
"styleguide": "styleguidist server", | ||
"styleguide:build": "styleguidist build" | ||
} | ||
"name": "react-styleguidist-example-cra", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert the indentation changes.
examples/cra/Readme.md
Outdated
@@ -7,7 +7,7 @@ How to start locally: | |||
``` | |||
git clone https://github.com/styleguidist/react-styleguidist.git | |||
cd react-styleguidist/examples/cra | |||
npm install | |||
npm install (or yarn install) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make sense to make this change in just one example, and I'm sure the issues isn't related to npm/yarn. They both install the same packages. Also now you can't copy the code and paste it into the terminal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. I thought it might be related to #1321 since it only worked when I used yarn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be some minor differences in version resolution between npm and Yarn. But you can't say that using Yarn actually fixes the issue. Tomorrow it could be the opposite.
Could you please merge master, it should fix the CI failures? |
Codecov Report
|
@sapegin Done. Sorry it took me so long! |
Thanks! |
🎉 This PR is included in version 10.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Ran into the following error preventing the CRA example from building:
After updating the packages I ran into another error in the browser console resulting in errors in place of the component examples:
I found that installing dependencies with yarn got past the issue. So I updated the readme with yarn as a suggested alternative.