Add tags to ComponentDoc #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohantalkad747
force-pushed
the
master
branch
from
6de37a0 to
ebf4f26
Compare
pvasek
reviewed
Oct 28, 2020
package.json
Outdated
| @@ -9,6 +9,7 @@ | |||
| "scripts": { | |||
| "precommit": "lint-staged", | |||
| "tsc": "tsc", | |||
| "postinstall": "tsc --outDir ./lib", | |||
There was a problem hiding this comment.
Could you explain, why it's a good idea, to have this postinstall script here? I thought it's run after npm install which doesn't seem to make too much sense or am I missing something?
There was a problem hiding this comment.
Sorry about that, I was using that Github fork for my own project hence why I have a postInstall script there. I have since removed it.
tsconfig.json
Outdated
| @@ -4,6 +4,7 @@ | |||
| "lib": ["es5", "es6"], | |||
| "target": "es5", | |||
| "strict": true, | |||
| "noImplicitAny": false, | |||
There was a problem hiding this comment.
It had taken a lot of effort to fix all things to enable this and make our code safer. Why we should disable it now?
There was a problem hiding this comment.
I have removed that line.
There was a problem hiding this comment.
Oh, my mistake, I thought you change it. Sorry about that.
rohantalkad747
force-pushed
the
master
branch
from
5e2dbf3 to
15ee5f2
Compare
rohantalkad747
force-pushed
the
master
branch
from
15ee5f2 to
50e2000
Compare
rohantalkad747
force-pushed
the
master
branch
from
50e2000 to
52a1062
Compare
pvasek
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is proposed that the tagMap object be present in ComponentDoc. This can help developers use any tags to customize or filter the components.