Fix upper group limit in GroupedTag #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitten
commented
Jan 30, 2020
|
|
||
| /** Create a GroupedTag with an underlying Tag implementation */ | ||
| export const makeGroupedTag = (tag: Tag): GroupedTag => { | ||
| return new DefaultGroupedTag(tag); | ||
| }; | ||
|
|
||
| const BASE_SIZE = 1 << 8; | ||
| const BASE_SIZE = 1 << 9; |
There was a problem hiding this comment.
I've increased the base-size here since I find it highly likely that a lot of apps will actually have around 512 components usually. Larger apps will of course see this grow as usual
kitten
commented
Jan 30, 2020
| let newSize = oldSize; | ||
| while (group >= newSize) { | ||
| newSize <<= 1; | ||
| if (newSize < 0) { |
There was a problem hiding this comment.
This works because eventually we'll hit 1 << 31 the upper limit of SMIs, where we overflow into the signed bit, which turns newSize negative.
quantizor
previously approved these changes
Jan 30, 2020
Previously the formula for increasing the size of Uint32Arrays in the GroupedTag was a little aggressive and would cut of very short of 2^31 groups. Instead it would cut off between 2^12 and 2^13 components, which isn't quite a lot. This new upper boundary is the absolute limit of how many slots a Uint32Array is defined to be able to hold. After this limit we'll see an error. Instead of letting this error leak out we now throw a more clear error that hints at this limitation.
We can make it easier to track the offending dynamic components in development by adding another SMI overflow check to the GroupIDAllocator
kitten
force-pushed
the
fix/upper-group-limit
branch
from
8b023c6 to
9b4cbb4
Compare
|
This is published as the prerelease |
|
@kitten throw a changelog entry in there too when you get a moment :) |
This was referenced Mar 4, 2020
Merged
This was referenced Mar 10, 2020
Merged
This was referenced Apr 9, 2020
Merged
Merged
[Snyk] Upgrade styled-components from 5.0.1 to 5.1.0
FDMediagroep/fd-ts-react-breaking-news-alert#47
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2994
Fix #2979
Previously the formula for increasing the size of Uint32Arrays
in the GroupedTag was a little aggressive and would cut of very
short of 2^31 groups. Instead it would cut off between 2^12 and
2^13 components, which isn't quite a lot.
This new upper boundary is the absolute limit of how many slots
a Uint32Array is defined to be able to hold. After this limit we'll
see an error.
Instead of letting this error leak out we now throw a more clear
error that hints at this limitation.
I've also refactored
dom.jsto finally usethrowStyledErroras well.Tests have been updated to reflect all changes.