Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved accessibility in Slider/Navigation.tsx and UserLogos/index.tsx #944

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

rohitmitt
Copy link
Contributor

Addressing Issue #904 - Enhance Accessibility

  • On the Showcase page, users were unable to access the left and right slider navigators for displaying the previous and next company showcases. These navigators rely on left and right arrow keys for interaction.

  • I've added HTML attributes that allow users to tab to these sections of the page, and I've provided clear instructions for navigation. Although these elements are buttons, the instruction "use left/right arrow to navigate" should suffice for users with impairments.

Here is the change visualized. Changes were made in Slider/Navigation.tsx.

navigation.tsx.mp4

Addressing Issue #769 - Pause Logo Scrolling Animation

  • This issue suggested allowing users to 'pause' scrolling animated content in compliance with WCAG 2.1 Criterion 2.2.2: Pause, Stop, Hide. Here's how I resolved it:

  • I implemented a simple solution using React's useState hook, which identifies the current state of the moving content 'UserLogos'. Users can now click the container to toggle the CSS animationPlayState property between 'paused' and 'running'. Additionally, I've added a pointer cursor to the logo section to indicate that it's a clickable field.

Here is the change visualized. Changes were made in UserLogos/index.tsx.

index.tsx.mp4

Copy link
Contributor

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions, thank you!

@quantizor quantizor merged commit 1913608 into styled-components:main Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants