Refactor Layout #915
Merged
Refactor Layout #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantizor
reviewed
May 19, 2023
utils/media.ts
Outdated
| import { css } from 'styled-components'; | ||
| import { RuleSet } from 'styled-components/dist/types'; | ||
|
|
||
| export const mobile = (inner: ReturnType<typeof css>): RuleSet<object> => css` |
There was a problem hiding this comment.
You should be able to remove RuleSet<object> for these and use the same ReturnType<typeof css> annotation. Perhaps store it to a local type so you can reuse it?
type CSSUtilType = ReturnType<typeof css>
|
Thanks for helping with this work! Should be good to merge after that last small refactoring. |
fixed & pushed |
you're very welcome! ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Layout component (JS ->TS convertion), 'media' and 'rem' utils; add typings
fixes #902